On Sun, Jun 27, 2021 at 05:27:41PM -0700, Stephen Boyd wrote: > Quoting Shawn Guo (2021-05-03 22:28:40) > > The clock source for MSM8916 cpu cores is like below. > > > > |\ > > a53pll --------| \ a53mux +------+ > > | |------------| cpus | > > gpll0_vote --------| / +------+ > > |/ > > > > So clock a53mux rather than a53pll is actually the clock source of cpu > > cores. It makes more sense to flag a53mux rather than a53pll as > > critical, since a53pll could be irrelevant if a53mux switches its parent > > clock to be gpll0_vote. > > Can you add some more detail here? I think the idea is to mark the mux > as critical so that either a53pll or gpll0_vote is kept enabled, but > only if they're used by the CPU. That isn't very clear from the commit > text. Otherwise it seems OK. Sure. I will rewrite the commit log. Shawn