Quoting Shawn Guo (2021-05-03 22:28:42)
> Unlike MSM8916 which has only one APCS clock, MSM8939 gets three for
> Cluster0 (little cores), Cluster1 (big cores) and CCI (Cache Coherent
> Interconnect). Instead of hard coding APCS (and A53PLL) clock name,
> retrieve the name from DT, so that multiple APCS clocks can be
> registered.
>
> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> ---
> drivers/clk/qcom/a53-pll.c | 5 ++++-
> drivers/clk/qcom/apcs-msm8916.c | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
> index 8614b0b0e82c..964f5ab7d02f 100644
> --- a/drivers/clk/qcom/a53-pll.c
> +++ b/drivers/clk/qcom/a53-pll.c
> @@ -42,6 +42,7 @@ static int qcom_a53pll_probe(struct platform_device *pdev)
> struct clk_pll *pll;
> void __iomem *base;
> struct clk_init_data init = { };
> + const char *clk_name = NULL;
> int ret;
>
> pll = devm_kzalloc(dev, sizeof(*pll), GFP_KERNEL);
> @@ -66,7 +67,9 @@ static int qcom_a53pll_probe(struct platform_device *pdev)
> pll->status_bit = 16;
> pll->freq_tbl = a53pll_freq;
>
> - init.name = "a53pll";
> + of_property_read_string(pdev->dev.of_node, "clock-output-names",
> + &clk_name);
Please no? Is there any use for this? Why not just generate the name as
a53pll@<MMIO ADDRESS>?
> + init.name = clk_name ? clk_name : "a53pll";
> init.parent_names = (const char *[]){ "xo" };
> init.num_parents = 1;
> init.ops = &clk_pll_sr2_ops;
