On Mon, Jun 21, 2021 at 08:46:29PM +0530, manivannan.sadhasivam@xxxxxxxxxx wrote: > + linux-arm-msm > > On Mon, Jun 21, 2021 at 09:04:17AM +0000, ULRICH Thomas wrote: > > This patch adds VendorID/ProductID and MBIM Channel Definitions for M.2 Modem Card (PCIe Variant) to MHI: > > Cinterion MV31-W (by Thales) > > Additional information on such Modem Card (USB or PCIe variant) is e.g. available at: > > https://www.thalesgroup.com/en/markets/digital-identity-and-security/iot/iot-connectivity/products/iot-products/mv31-w-ultra-high > > > > Signed-off-by: Thomas Ulrich <thomas.ulrich@xxxxxxxxxxxxxxx> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > There were multiple checkpatch errors while trying to apply this patch. But I just fixed them and applied. Please make sure to run checkpatch.pl script for future patches. Thanks, Mani > > > > --- > > drivers/bus/mhi/pci_generic.c | 37 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > > > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c > > index 56f710763e36..5e263794d4c5 100644 > > --- a/drivers/bus/mhi/pci_generic.c > > +++ b/drivers/bus/mhi/pci_generic.c > > [...] > > > +static const struct mhi_pci_dev_info mhi_mv31_info = { > > + .name = "cinterion-mv31", > > + .config = &modem_mv31_config, > > + .bar_num = MHI_PCI_DEFAULT_BAR_NUM, > > + .dma_data_width = 32 > > As per 704d98540e55, there needs to be: > > .sideband_wake = false, > > I'll add it while applying. > > Thanks, > Mani > > > +}; > > + > > static const struct pci_device_id mhi_pci_id_table[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306), > > .driver_data = (kernel_ulong_t) &mhi_qcom_sdx55_info }, > > @@ -369,6 +403,9 @@ static const struct pci_device_id mhi_pci_id_table[] = { > > /* DW5930e (sdx55), Non-eSIM, It's also T99W175 */ > > { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0b1), > > .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info }, > > + /* MV31-W (Cinterion) */ > > + { PCI_DEVICE(0x1269, 0x00b3), > > + .driver_data = (kernel_ulong_t) &mhi_mv31_info }, > > { } > > }; > > MODULE_DEVICE_TABLE(pci, mhi_pci_id_table); > > -- > > 2.20.1 > >