On Tue 15 Jun 19:58 CDT 2021, Konrad Dybcio wrote: [..] > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi [..] > @@ -3490,6 +3508,89 @@ data { > bias-pull-up; > }; > }; > + > + pcie0_default_state: pcie0-default { I thought I answered the other way around (that it should be in the board file), that said I don't think these are moving much, so I'm not against keeping them here. > + pcie0_perst_default: perst { > + pins = "gpio79"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + clkreq { > + pins = "gpio80"; > + function = "pci_e0"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + wake { > + pins = "gpio81"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + }; [..] > + > + mdm2ap_default: mdm2ap-default { These however are presumably only present on devices with SDX55, so please move these two to your board file. Thanks, Bjorn