On Sun, Jun 13 2021 at 12:20:53 AM +0300, Alexey Minnekhanov
<alexeymin@xxxxxxxxxxxxxxxx> wrote:
> + sdhc_1: sdhci@4744000 {
+ compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5";
+ reg = <0x04744000 0x1000>, <0x04744000 0x1000>;
+ reg-names = "hc_mem", "core_mem";
ichernev: reg-names should be "hc" and "cqhci" and the 2 values
you've supplied should be different maybe?
Actually reg-names are OK to use like this. Driver will accept both hc
and hc_mem and the same for core.
The getresource function in the driver most likely checks for both as
other DTS files have hc_mem as well.
But i will change them in V3 to follow the bindings properly.
I will check if they should be different.
+
+ sdhc_2: sdhci@4784000 {
+ compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5";
+ reg = <0x04784000 0x1000>;
+ reg-names = "hc_mem";
Wrong reg names again?
Same as above.
Thank you for the suggestions.
Best regards,
Martin Botka
