On Fri, Jun 11, 2021 at 11:31:17AM -0700, Jakub Kicinski wrote: > On Fri, 11 Jun 2021 09:00:16 +0200 Loic Poulain wrote: > > > On Fri, May 21, 2021 at 03:25:19PM +0200, Loic Poulain wrote: > > > > Currently, the MHI controller driver defines which channels should > > > > have their inbound buffers allocated and queued. But ideally, this is > > > > something that should be decided by the MHI device driver instead, > > > > which actually deals with that buffers. > > > > > > > > Add a flag parameter to mhi_prepare_for_transfer allowing to specify > > > > if buffers have to be allocated and queued by the MHI stack. > > > > > > > > Keep auto_queue flag for now, but should be removed at some point. > > > > > > > > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx> > > > > Tested-by: Bhaumik Bhatt <bbhatt@xxxxxxxxxxxxxx> > > > > Reviewed-by: Bhaumik Bhatt <bbhatt@xxxxxxxxxxxxxx> > > > > Reviewed-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx> > > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > > --- > > > > v2: Update API in mhi_wwan_ctrl driver > > > > > > > > drivers/bus/mhi/core/internal.h | 2 +- > > > > drivers/bus/mhi/core/main.c | 11 ++++++++--- > > > > drivers/net/mhi/net.c | 2 +- > > > > drivers/net/wwan/mhi_wwan_ctrl.c | 2 +- > > > > > > Since this patch touches the drivers under net/, I need an Ack from Dave or > > > Jakub to take it via MHI tree. > > > > Could you please ack|nack this patch? > > Looks fine. Thanks, I'll take it as an Ack. Regards, Mani
