On Wed, May 19, 2021 at 12:49:16AM -0700, Wesley Cheng wrote: > Changes in V9: > - Fixed incorrect patch in series. Removed changes in DTSI, as dwc3-qcom will > add the property by default from the kernel. This patch series has one build failure and one warning added: drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_calc_tx_fifo_size’: drivers/usb/dwc3/gadget.c:653:45: warning: passing argument 1 of ‘dwc3_mdwidth’ makes pointer from integer without a cast [-Wint-conversion] 653 | mdwidth = dwc3_mdwidth(dwc->hwparams.hwparams0); | ~~~~~~~~~~~~~^~~~~~~~~~ | | | u32 {aka unsigned int} In file included from drivers/usb/dwc3/debug.h:14, from drivers/usb/dwc3/gadget.c:25: drivers/usb/dwc3/core.h:1493:45: note: expected ‘struct dwc3 *’ but argument is of type ‘u32’ {aka ‘unsigned int’} 1493 | static inline u32 dwc3_mdwidth(struct dwc3 *dwc) | ~~~~~~~~~~~~~^~~ drivers/usb/dwc3/dwc3-qcom.c: In function ‘dwc3_qcom_of_register_core’: drivers/usb/dwc3/dwc3-qcom.c:660:23: error: implicit declaration of function ‘of_add_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration] 660 | ret = of_add_property(dwc3_np, prop); | ^~~~~~~~~~~~~~~ | of_get_property How did you test these? thanks, greg k-h