Re: [v1 2/3] drm/msm/dsi: Add PHY configuration for SC7280

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31-05-2021 23:27, Dmitry Baryshkov wrote:
On 31/05/2021 16:33, Rajeev Nandan wrote:


+	.min_pll_rate = 600000000UL,
+ .max_pll_rate = (5000000000ULL < ULONG_MAX) ? 5000000000ULL : ULONG_MAX,

Could you please follow the patch by Arnd here?
https://lore.kernel.org/linux-arm-msm/20210514213032.575161-1-arnd@xxxxxxxxxx/



+	.io_start = { 0xae94400, 0xae96400 },
+	.num_dsi_phy = 2,

Judging from the next patch, you have one DSI host and one DSI PHY.
Could you please correct io_start / num_dsi_phy here?

+	.quirks = DSI_PHY_7NM_QUIRK_V4_1,
+};


With these two issues fixed:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Thank you very much for your review :) I have incorporated the
review comments. I am waiting for comments on my DT bindings patch (1/3) and
will send v2 in a day or two.

Thanks,
Rajeev



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux