On Fri 21 May 16:58 CDT 2021, Sujit Kautkar wrote: > Trogdor board does not have external pull-up for cd-gpio. Set this pin This says "Trogdor" specifically, but the diffstats says "all 7180 devices". > to internal pull-up for sleep config to avoid frequent regulator toggle > events. > > This change is aligned with Qualcomm's DT change posted at: > https://patchwork.kernel.org/patch/11675347/ > I'm sorry, but afacit this says that your v2 is Qualcomm's v2 but with the change I asked for. If this is the case, then your patch is either v3 or you could just mention this below the '---', as I don't see any benefit of carrying this in the git history. Regards, Bjorn > Signed-off-by: Sujit Kautkar <sujitka@xxxxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > Changes in v2: > - added pull-up for IDP > > (no changes since v1) > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 07133e0af581a..0c255edb7f3c3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -696,7 +696,7 @@ pinconf-data { > > pinconf-sd-cd { > pins = "gpio69"; > - bias-disable; > + bias-pull-up; > drive-strength = <2>; > }; > }; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index d128a0ed6ad3a..330deb4967ca2 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -1638,7 +1638,7 @@ pinconf-data { > > pinconf-sd-cd { > pins = "gpio69"; > - bias-disable; > + bias-pull-up; > drive-strength = <2>; > }; > }; > -- > 2.31.1.818.g46aad6cb9e-goog >
