Hi Martin, overall this looks good but the bot warned because of this: On Mon, May 24, 2021 at 9:30 PM Martin Botka <martin.botka@xxxxxxxxxxxxxx> wrote: > > Document the newly added SM6125 pinctrl driver > > Signed-off-by: Martin Botka <martin.botka@xxxxxxxxxxxxxx> (...) > +properties: > + compatible: > + const: qcom,sm6125-tlmm (...) > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + pinctrl@500000 { > + compatible = "qcom,sm6125-pinctrl"; So it seems like you didn't run the checks? Yours, Linus Walleij