Hi, > So I'm supposed to include this and the pmi8994? I was expecting an > include of pmi8994.dtsi from here and then some override of the > necessary properties. This way we would have to get three dts files for each device: one for device-common stuff, one including pmi8994 and one including pmi8996. Otherwise pmi8994 contents would be included twice, as the "base" device dt already includes pmi8994. If you check how I solved that on Tone, I just took the pmi8994-equipped phone dt as a baseline and only included this small dtsi as an overlay on top. Konrad
