Hello Jeff, On 21-05-21, 08:09, Jeffrey Hugo wrote: > On Fri, May 21, 2021 at 6:50 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote: > > > > Display Stream Compression (DSC) compresses the display stream in host which > > is later decoded by panel. This series enables this for Qualcomm msm driver. > > This was tested on Google Pixel3 phone which use LGE SW43408 panel. > > > > The changes include adding DT properties for DSC then hardware blocks support > > required in DPU1 driver and support in encoder. We also add support in DSI > > and introduce required topology changes. > > > > In order for panel to set the DSC parameters we add dsc in drm_panel and set > > it from the msm driver. > > > > Complete changes which enable this for Pixel3 along with panel driver (not > > part of this series) and DT changes can be found at: > > git.linaro.org/people/vinod.koul/kernel.git pixel/dsc_rfc > > > > Comments welcome! > > This feels backwards to me. I've only skimmed this series, and the DT > changes didn't come through for me, so perhaps I have an incomplete > view. Not sure why, I see it on lore: https://lore.kernel.org/dri-devel/20210521124946.3617862-3-vkoul@xxxxxxxxxx/ > DSC is not MSM specific. There is a standard for it. Yet it looks > like everything is implemented in a MSM specific way, and then pushed > to the panel. So, every vendor needs to implement their vendor > specific way to get the DSC info, and then push it to the panel? > Seems wrong, given there is an actual standard for this feature. I have added slice and bpp info in the DT here under the host and then pass the generic struct drm_dsc_config to panel which allows panel to write the pps cmd Nothing above is MSM specific.. It can very well work with non MSM controllers too. I didn't envision DSC to be a specific thing, most of the patches here are hardware enabling ones for DSC bits for MSM hardware. > Additionally, we define panel properties (resolution, BPP, etc) at the > panel, and have the display drivers pull it from the panel. However, > for DSC, you do the reverse (define it in the display driver, and push > it to the panel). If the argument is that DSC properties can be > dynamic, well, so can resolution. Every panel for MSM MTPs supports > multiple resolutions, yet we define that with the panel in Linux. I dont have an answer for that right now, to start with yes the properties are in host but I am okay to discuss this and put wherever we feel is most correct thing. I somehow dont like that we should pull from panel DT and program host with that. Here using struct drm_dsc_config allows me to configure panel based on resolution passed > Finally, I haven't seen the DT bits, but I'm concerned about using DT > for this. It inherently excludes ACPI systems. You appear to have > sdm845 support in this series, but what about ACPI boot on the Lenovo > C630 for example? Or any of the 8cx laptops? We don't read the panel > resolution, etc from DT, so why the DSC? But you must read from somewhere like ACPI tables. I think ACPI systems would have some ACPI table info out there which would help on this. Yes that is another task which we need to start with once we enable OF systems. Thanks -- ~Vinod
