On Mon, May 17, 2021 at 03:12:02PM +0530, Vinod Koul wrote: > On 15-05-21, 17:52, Jonathan McDowell wrote: > > > gcc: clock-controller@900000 { > > - compatible = "qcom,gcc-ipq8064"; > > + compatible = "qcom,gcc-ipq8064", "syscon"; > > Does this belong here No, not sure how that slipped in, will remove for v2. > > reg = <0x00900000 0x4000>; > > #clock-cells = <1>; > > #reset-cells = <1>; > > + #power-domain-cells = <1>; > > + > > + tsens: thermal-sensor@900000 { > > + compatible = "qcom,ipq8064-tsens"; > > + > > + nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>; > > + nvmem-cell-names = "calib", "calib_backup"; > > + interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "uplow"; > > + > > + #qcom,sensors = <11>; > > + #thermal-sensor-cells = <1>; > > + }; > > We have sensor under gcc node..? Weirdly, yes, that seems to be where it lives for the 8064. J. -- I'm dangerous when I know what I'm doing.