On Thu, May 06, 2021 at 03:27:26PM -0500, Rob Herring wrote:
> On Tue, May 04, 2021 at 01:28:41PM +0800, Shawn Guo wrote:
> > Update qcom,a53pll bindings for MSM8939 support:
> >
> > - Add optional clock-output-names property.
> > - Add MSM8939 specific compatibles.
> > - Add MSM8939 examples.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> > ---
> > .../bindings/clock/qcom,a53pll.yaml | 34 +++++++++++++++++++
> > 1 file changed, 34 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> > index db3d0ea6bc7a..7a410a76be2f 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> > @@ -18,6 +18,9 @@ properties:
> > enum:
> > - qcom,ipq6018-a53pll
> > - qcom,msm8916-a53pll
> > + - qcom,msm8939-a53pll-c0
> > + - qcom,msm8939-a53pll-c1
> > + - qcom,msm8939-a53pll-cci
>
> These 3 have differences?
Yes. They need to hook up with different frequency table as shown in
patch #5.
>
> >
> > reg:
> > maxItems: 1
> > @@ -33,6 +36,9 @@ properties:
> > items:
> > - const: xo
> >
> > + clock-output-names:
> > + maxItems: 1
> > +
> > required:
> > - compatible
> > - reg
> > @@ -57,3 +63,31 @@ examples:
> > clocks = <&xo>;
> > clock-names = "xo";
> > };
> > + #Example 3 - A53 PLLs found on MSM8939 devices
> > + - |
> > + a53pll_c1: clock-controller@b016000 {
> > + compatible = "qcom,msm8939-a53pll-c1";
> > + reg = <0xb016000 0x40>;
> > + #clock-cells = <0>;
> > + clocks = <&xo_board>;
> > + clock-names = "xo";
> > + clock-output-names = "a53pll_c1";
> > + };
> > +
> > + a53pll_c0: clock-controller@b116000 {
> > + compatible = "qcom,msm8939-a53pll-c0";
> > + reg = <0xb116000 0x40>;
> > + #clock-cells = <0>;
> > + clocks = <&xo_board>;
> > + clock-names = "xo";
> > + clock-output-names = "a53pll_c0";
> > + };
> > +
> > + a53pll_cci: clock-controller@b1d0000 {
> > + compatible = "qcom,msm8939-a53pll-cci";
> > + reg = <0xb1d0000 0x40>;
> > + #clock-cells = <0>;
> > + clocks = <&xo_board>;
> > + clock-names = "xo";
> > + clock-output-names = "a53pll_cci";
> > + };
>
> Do these examples really add anything?
The example was added to demonstrate that multiple A53PLL clock
controllers could be found on a single SoC. But I'm happy to drop it
if you think it's not so useful.
Shawn
