Hi Sibi, On Tue, May 04, 2021 at 11:55:10PM +0530, Sibi Sankar wrote: > Hey Sudeep, > > Thanks for the review! > > On 2021-05-04 20:12, Sudeep Holla wrote: [...] > > > > NACK, this breaks if there is a mismatch from what is read from the > > hardware and what is presented in this table above. Either add it from the > > some bootloader or other boot code to this table reading from the > > hardware/firmware or find a way to link them without this. > > > > Sorry I had warned long back about this when such links were discussed > > as part of interconnect binding. > > Not sure why this warrants a NACK, as this was consensus for mapping cpu > freq to DDR/L3 bandwidth votes. (We use the same solution on SDM845 and > SC7180). The opp tables are optional and when specified puts in votes for > DDR/L3. In the future the table can be safely dropped when more useful > devfreq governors are upstreamed. > cpufreq: qcom: Don't add frequencies without an OPP (You can always add commit sha to make it easy to search) But I am not sure how this is related to the above commit anyways. > > I guess your main concern for breakage is ^^ commit? The original design is > to list a super set of frequencies supported by all variants of the SoC > along with the required DDR/L3 bandwidth values. When we run into > non-documented frequency we just wouldn't put in bw votes for it which > should be fine since the entire opp_table is optional. If this is the reason > for the NACK I can try get it reverted with Matthias's ack. No my main concern is this platform uses "qcom-cpufreq-hw" driver and the fact that the OPPs are retrieved from the hardware lookup table invalidates whatever we have in DT. In short it will be junk and becomes obsolete. So what I suggested before is still valid. You simply can't have static OPP tables in the DT for this platform. Do get some boot code to fetch the same from the h/w LUT and patch to the DT or figure out any other way to manage dynamically. So NACK still stands for static addition of OPPs to the DT as in this patch. -- Regards, Sudeep
