Re: [PATCH] usb: dwc3: gadget: Free gadget structure only after freeing endpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jack,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on peter.chen-usb/for-usb-next linus/master balbi-usb/testing/next v5.12 next-20210430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jack-Pham/usb-dwc3-gadget-Free-gadget-structure-only-after-freeing-endpoints/20210501-173239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-a012-20210501 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8f5a2a5836cc8e4c1def2bdeb022e7b496623439)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/5b2764c7c290946657e27890a4265bd11bccc0dc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jack-Pham/usb-dwc3-gadget-Free-gadget-structure-only-after-freeing-endpoints/20210501-173239
        git checkout 5b2764c7c290946657e27890a4265bd11bccc0dc
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/usb/dwc3/gadget.c:4063:2: error: implicit declaration of function 'usb_del_gadget_put' [-Werror,-Wimplicit-function-declaration]
           usb_del_gadget_put(dwc->gadget);
           ^
   drivers/usb/dwc3/gadget.c:4063:2: note: did you mean 'usb_del_gadget_udc'?
   include/linux/usb/gadget.h:477:13: note: 'usb_del_gadget_udc' declared here
   extern void usb_del_gadget_udc(struct usb_gadget *gadget);
               ^
   1 error generated.


vim +/usb_del_gadget_put +4063 drivers/usb/dwc3/gadget.c

  4058	
  4059	void dwc3_gadget_exit(struct dwc3 *dwc)
  4060	{
  4061		usb_del_gadget(dwc->gadget);
  4062		dwc3_gadget_free_endpoints(dwc);
> 4063		usb_del_gadget_put(dwc->gadget);
  4064		dma_free_coherent(dwc->sysdev, DWC3_BOUNCE_SIZE, dwc->bounce,
  4065				  dwc->bounce_addr);
  4066		kfree(dwc->setup_buf);
  4067		dma_free_coherent(dwc->sysdev, sizeof(*dwc->ep0_trb) * 2,
  4068				  dwc->ep0_trb, dwc->ep0_trb_addr);
  4069	}
  4070	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux