On Fri, Apr 23, 2021 at 12:59 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to
> avoid excessive unprepare / prepare") we started using pm_runtime, but
> my patch neglected to add the proper pm_runtime_disable(). Doh! Add
> them now.
>
> Fixes: 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
> Reported-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
> Changes in v5:
> - Missing pm_runtime_disable() patch new for v5.
>
> drivers/gpu/drm/panel/panel-simple.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 6b22872b3281..9746eda6f675 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -797,12 +797,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
>
> err = drm_panel_of_backlight(&panel->base);
> if (err)
> - goto free_ddc;
> + goto disable_pm_runtime;
>
> drm_panel_add(&panel->base);
>
> return 0;
>
> +disable_pm_runtime:
> + pm_runtime_disable(dev);
> free_ddc:
> if (panel->ddc)
> put_device(&panel->ddc->dev);
> @@ -818,6 +820,7 @@ static int panel_simple_remove(struct device *dev)
> drm_panel_disable(&panel->base);
> drm_panel_unprepare(&panel->base);
>
> + pm_runtime_disable(dev);
> if (panel->ddc)
> put_device(&panel->ddc->dev);
>
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
