Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sebastian,

On 2021-04-09 13:48, skakit@xxxxxxxxxxxxxx wrote:
Hi Sebastian,

On 2021-04-08 18:30, Sebastian Reichel wrote:
Hi,

On Thu, Apr 08, 2021 at 05:01:08PM +0530, satya priya wrote:
Convert qcom PON binding from .txt to .yaml format.

Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
---

Thanks for doing this.

Changes in V2:
- As per Rob's comments, converted the main PON binding and added in V2.

[...]
+  reg:
+    description: Specifies the physical address of the pon register

That description is obvious and pointless. Instead add

maxItems: 1


Okay.

+  pwrkey:
+    type: object
+    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
+
+  resin:
+    type: object
+    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: true

Instead of allowing arbitrary properties, only valid modes
should be allowed. So drop additionalProperties and do this
instead:

allOf:
  - $ref: reboot-mode.yaml#

unevaluatedProperties: false


Okay.


I am not able to use 'allOf' to refer reboot-mode.yaml as some of the properties do not match with reboot-mode.yaml properties. Can we use oneOf like below?

oneOf:
  - $ref: "reboot-mode.yaml#"
  - $ref: "../../input/qcom,pm8941-pwrkey.yaml#"

Also, If I drop additionalProperties I am getting below error.

kernel/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml: 'additionalProperties' is a required property

Thanks,
Satya Priya



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux