On Fri, Apr 23, 2021 at 05:06:58PM +0100, Bryan O'Donoghue wrote: > + /* Set OTG current limit to 3000mA up from bootloader set 2000mA */ > + regmap_update_bits(regmap, base + OTG_CURRENT_LIMIT_CFG, > + OTG_CURRENT_LIMIT_MASK, OTG_CURRENT_LIMIT_3000MA); This seems like something that needs to be configured per system, the system may not be physically capable of delivering an additional amp (150% of the current defaults) safely. It's going to be better to be out of spec for high current USB devices than to exceed safe physical limits, there's a good solid reason why the regulator API never touches the hardware without explicit constraints allowing it to do so. I also thought there was support in the USB specs for negotiating how much power is drawn (not that everything will DTRT there but still)?
Attachment:
signature.asc
Description: PGP signature
