Hi,
Caleb Connolly <caleb@xxxxxxxxxxxxx> writes:
>> From: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxx>
>>
>> Add missing SPI nodes for SM8150.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxx>
>> ---
>>
>> changes since v2:
>> - switch to new pinctrl format
>>
>> Changes since v1:
>>
>> - avoid modifying drive strength on i2c. No functional
>> changes, just keeping 0x02 instead of 2
>>
>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 439 +++++++++++++++++++++++++++
>> 1 file changed, 439 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index 7207a3689d9d..c563f381a138 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -602,6 +602,21 @@ i2c0: i2c@880000 {
>> status = "disabled";
>> };
>>
>> + spi0: spi@880000 {
>> + compatible = "qcom,geni-spi";
>> + reg = <0 0x880000 0 0x4000>;
>> + reg-names = "se";
>
> I don't think we need the reg-names property on any of these.
true, but it doesn't hurt either :-) I can remove, but I'll wait before
spinning another revision
> Otherwise,
>
> Reviewed-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
Thanks
--
balbi
