Hi!
> Tested on Microsoft Surface Duo (DTS will be sent after -rc1).
Cool, along with the Lumias we'll now have all the MSFT arm64 qcom devices supported :)
>
> + qup_spi0_default: qup-spi0-default {
> + mux {
> + pins = "gpio0", "gpio1", "gpio2", "gpio3";
> + function = "qup0";
> + };
> +
> + config {
> + pins = "gpio0", "gpio1", "gpio2", "gpio3";
> + drive-strength = <6>;
> + bias-disable;
> + };
> + };
> +
This format - while technically still correct - is now considered obsolete. Please move the pin definitions into a more concise one, like so:
qup_spi0_default: qup-spi0-default {
pins = "gpio0", "gpio1", "gpio2", "gpio3";
function = "qup0";
drive-strength = <6>;
bias-disable;
};
(hopefully Thunderbird didn't mess up newlines here..)
Overall, the patch - while on the large side - looks correct to me. Thanks!
Konrad
