Re: [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yang,

Thanks for the patch.

On Fri, 9 Apr 2021 at 07:03, Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss-ispif.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
> index a30e453de162..37611c8861da 100644
> --- a/drivers/media/platform/qcom/camss/camss-ispif.c
> +++ b/drivers/media/platform/qcom/camss/camss-ispif.c
> @@ -1145,17 +1145,13 @@ int msm_ispif_subdev_init(struct camss *camss,
>
>         r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
>         ispif->base = devm_ioremap_resource(dev, r);
> -       if (IS_ERR(ispif->base)) {
> -               dev_err(dev, "could not map memory\n");
> +       if (IS_ERR(ispif->base))
>                 return PTR_ERR(ispif->base);
> -       }
>
>         r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]);
>         ispif->base_clk_mux = devm_ioremap_resource(dev, r);
> -       if (IS_ERR(ispif->base_clk_mux)) {
> -               dev_err(dev, "could not map memory\n");
> +       if (IS_ERR(ispif->base_clk_mux))
>                 return PTR_ERR(ispif->base_clk_mux);
> -       }
>
>         /* Interrupt */
>

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux