On Thu, 8 Apr 2021 at 04:08, Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > Quoting Dmitry Baryshkov (2021-04-07 17:38:06) > > Hello, > > > > On Thu, 8 Apr 2021 at 03:20, Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > > > > > Quoting Dmitry Baryshkov (2021-04-06 16:19:06) > > > > Separate qcom,gcc-sdm845 clock bindings, adding required clocks and > > > > clock-names properties. > > > > > > Yes, but why? > > > > Why separate or why add required clocks? Consider the rest of > > Why separate the binding from the overall gcc one. > > > bindings, where qcom,gcc.yaml defines older bindings, which do not use > > clocks/clock-names and for newer bindings we have one file per binding > > (qcom,gcc-apq8064.yaml, qcom,gcc-qcs404.yaml, qcom,gcc-sdx55.yaml, > > qcom,gcc-sm8150.yaml, etc). > > > > Do you suggest merging all of them back into a single yaml file? > > No. Please add the "why" part to the commit text. The "how" and "what" > should be clear from the patch itself. I guess "so we can add required > clocks and clock-names properties to the binding" should be sufficient. Ah, got you. Sorry for the confusion. Will send v3 shortly. -- With best wishes Dmitry
