Hi, On Fri, Mar 19, 2021 at 5:54 AM Kalyan Thota <kalyan_t@xxxxxxxxxxxxxx> wrote: > > During crtc disable, display perf structures are reset to 0 > which includes state varibles which are immutable. On crtc > enable, we use the same structures and they don't refelect > the actual values > > 1) Fix is to avoid updating the state structures during disable. > 2) Reset the perf structures during atomic check when there is no > modeset enable. > > Signed-off-by: Kalyan Thota <kalyan_t@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 1 - > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) I think Stephen was the one who originally noticed this and reported it, so: Reported-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> Seems to work for me. I got into the state where it was doing a modeset at reboot (could see the underflow color for a period of time when this happened). I added your patch and it looks better. Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
