On 18-03-21, 09:08, Georgi Djakov wrote: > Hi Vinod, > > On 3/2/21 15:43, Vinod Koul wrote: > > Add driver for the Qualcomm interconnect buses found in SM8i350 based > > Still SM8i350? Have you checked my comments on v1? Oops missed to fix the commit log :( > > +config INTERCONNECT_QCOM_SM8350 > > + tristate "Qualcomm SM8350 interconnect driver" > > + depends on INTERCONNECT_QCOM > > + depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST > > Again: depends on INTERCONNECT_QCOM_RPMH_POSSIBLE fixed now > > +#include <linux/device.h> > > +#include <linux/interconnect.h> > > +#include <linux/interconnect-provider.h> > > +#include <linux/module.h> > > +#include <linux/of_device.h> > > +#include <linux/of_platform.h> > > Is this used? I need either of_device or of_platform, not both :) I decided to keep of_device and also get rid of device.h Also checked we can remove interconnect.h as interconnect-provider.h already has it. So will send these in next version shortly -- ~Vinod
