Hi, On Sat, Mar 13, 2021 at 10:11 PM Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx> wrote: > > From: Ajit Pandey <ajitp@xxxxxxxxxxxxxx> > > Add dai link for supporting lpass I2S driver, which is used > for audio capture and playback. > Add lpass-cpu node with pin controls and i2s primary > and secondary dai-links You missed Stephen's comments on your commit message [1] [1] https://lore.kernel.org/r/161566899554.1478170.1265435102634351195@xxxxxxxxxxxxxxxxxxxxxxxxxx/ > Signed-off-by: Ajit Pandey <ajitp@xxxxxxxxxxxxxx> > Signed-off-by: V Sujith Kumar Reddy <vsujithk@xxxxxxxxxxxxxx> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 ++++++++++++++++++++ > 1 file changed, 58 insertions(+) The commit message nits aren't terribly important and Bjorn can presumably just fix them when applying if he cares. IMO you don't need to re-spin. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> With these two patches plus commit 9922f50f7178 ("ASoC: qcom: lpass-cpu: Fix lpass dai ids parse") in the sound tree I get audio on sc7180-trogdor-lazor! Thus: Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
