On Tue, 9 Mar 2021 at 09:19, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Mar 08, 2021 at 09:59:27PM +0100, Loic Poulain wrote: > > The MHI WWWAN control driver allows MHI Qcom based modems to expose > > different modem control protocols to userspace, so that userspace > > modem tools or daemon (e.g. ModemManager) can control WWAN config > > and state (APN config, SMS, provider selection...). A Qcom based > > modem can expose one or several of the following protocols: > > - AT: Well known AT commands interactive protocol (microcom, minicom...) > > - MBIM: Mobile Broadband Interface Model (libmbim, mbimcli) > > - QMI: Qcom MSM/Modem Interface (libqmi, qmicli) > > - QCDM: Qcom Modem diagnostic interface (libqcdm) > > - FIREHOSE: XML-based protocol for Modem firmware management > > (qmi-firmware-update) > > > > The different interfaces are exposed as character devices, in the same > > way as for USB modem variants. > > > > Note that this patch is mostly a rework of the earlier MHI UCI > > tentative that was a generic interface for accessing MHI bus from > > userspace. As suggested, this new version is WWAN specific and is > > dedicated to only expose channels used for controlling a modem, and > > for which related opensource user support exist. Other MHI channels > > not fitting the requirements will request either to be plugged to > > the right Linux subsystem (when available) or to be discussed as a > > new MHI driver (e.g AI accelerator, WiFi debug channels, etc...). > > > > Co-developed-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx> > > Signed-off-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx> > > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx> > > --- > > v2: update copyright (2021) > > > > drivers/bus/mhi/Kconfig | 12 + > > drivers/bus/mhi/Makefile | 3 + > > drivers/bus/mhi/wwan_ctrl.c | 559 ++++++++++++++++++++++++++++++++++++++++++++ > > As Jakub said, why is this file in this directory? > > Flat out ignoring review comments is a sure way to always get pushed to > the bottom of the list of things anyone wants to ever look at... Yes, it's a legacy of the previous driver that was kind of a generic a mhi bus accessor. I'm going to move it inside network since it's about WWAN. Thanks, Loic > > greg k-h
