On Mon, Mar 01, 2021 at 09:43:28AM +0800, Shawn Guo wrote:
> It's not always the case that DT and ACPI describe hardware resource in
> the same schema, even for a single platform. For example, on SC8180X,
> DT uses the tiles schema while ACPI describe memory resource as a single
> region. It patches msm_pinctrl_probe() function to map tiles regions
> only for DT. While for ACPI, it maps the single memory resource and
> calculate tile bases with offsets passed from SoC data.
...
> +#include <linux/acpi.h>
No use of this header. See below.
(Perhaps you meant mod_devicetable.h)
...
> - if (soc_data->tiles) {
> + if (soc_data->tiles && !has_acpi_companion(&pdev->dev)) {
Any documentation to understand this change?
...
> + if (soc_data->tiles) {
> + for (i = 0; i < soc_data->ntiles; i++)
> + pctrl->regs[i] = base +
> + soc_data->tile_offsets[i];
> + } else {
> + pctrl->regs[0] = base;
> + }
And so this?
--
With Best Regards,
Andy Shevchenko
