On Tue, 9 Feb 2021 at 16:55, Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx> wrote: > > On 2/9/2021 8:53 AM, Loic Poulain wrote: > > mhi_deinit_chan_ctxt functionthat takes care of unitializing channel > > resources, including unmapping coherent MHI areas, can be called > > from different path in case of controller unregistering/removal: > > - From a client driver remove callback, via mhi_unprepare_channel > > - From mhi_driver_remove that unitialize all channels > > > > mhi_driver_remove() > > |-> driver->remove() > > | |-> mhi_unprepare_channel() > > | |-> mhi_deinit_chan_ctxt() > > |... > > |-> mhi_deinit_chan_ctxt() > > > > This leads to double dma freeing... > > > > Fix that by preventing deinit for already uninitialized channel. > > > > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx> > > Reported-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > > --- > > Seems like this should have a Fixes: tag, no? Right, thanks, i'll add it in V2 once I get feedback.
