On Wed, Feb 03, 2021 at 07:49:00AM +0100, Mauro Carvalho Chehab wrote:
> Hi Rob,
>
> Em Tue, 02 Feb 2021 11:44:54 -0600
> Rob Herring <robh@xxxxxxxxxx> escreveu:
>
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/snps,pcie.yaml: properties:snps,enable-cdm-check: 'oneOf' conditional failed, one must be fixed:
> > 'type' is a required property
> > Additional properties are not allowed ('$ref' was unexpected)
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/snps,pcie.yaml: properties:snps,enable-cdm-check: 'oneOf' conditional failed, one must be fixed:
> > 'enum' is a required property
> > 'const' is a required property
> > '/schemas/types.yaml#definitions/flag' does not match 'types.yaml#/definitions/'
You need a '/' between '#' and 'definitions'.
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/snps,pcie.yaml: ignoring, error in schema: properties: snps,enable-cdm-check
> > warning: no schema found in file: ./Documentation/devicetree/bindings/pci/snps,pcie.yaml
> >
> > See https://patchwork.ozlabs.org/patch/1434686
> >
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit.
>
> I've no idea why the bot is hitting those. My tree is based on
> staging-testing[1], as I need the regulator patches merged there.
> Such tree is based on v5.11-rc5.
>
> There, dt_binding_check doesn't get any warnings on this schema:
>
> $ pip3 install dtschema --upgrade --user
> Requirement already up-to-date: dtschema in /home/mchehab/.local/lib/python3.9/site-packages (2020.12)
This particular check is in master, but not yet a release on pypi. I'll
be tagging a release soon.
I've got this problem that adding new meta-schema checks like this one
requires fixing up all the existing in tree schemas first. So I give
some amount of time before adding them to a tagged release. However, I
want to start testing new schemas right away. I haven't come up with a
better solution short of importing the meta-schema into the kernel tree
or separately versioning them.
Rob
