Hi, On Sun, Jan 24, 2021 at 10:21 PM Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote: > > Let RPMH clients call rpmh_write_sleep_and_wake() to immediately > write cached sleep and wake data to the TCSes. > > Signed-off-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx> > --- > (no changes since v1) > --- > drivers/soc/qcom/rpmh.c | 16 ++++++++++++++++ > include/soc/qcom/rpmh.h | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c > index cbe6b96..725b8f0 100644 > --- a/drivers/soc/qcom/rpmh.c > +++ b/drivers/soc/qcom/rpmh.c > @@ -515,6 +515,22 @@ int rpmh_flush(struct rpmh_ctrlr *ctrlr) > } > > /** > + * rpmh_write_sleep_and_wake() - Writes the buffered wake and sleep sets > + * to TCSes > + * > + * @dev: The device making the request > + * > + * Return: > + * * 0 - Success > + * * Error code - Otherwise > + */ > +int rpmh_write_sleep_and_wake(const struct device *dev) > +{ > + return rpmh_flush(get_rpmh_ctrlr(dev)); > +} This patch doesn't hold weight on its own. Please squash with patch #3. Specifically any clients actually trying to call this function will hit the problems that patch #3 fixes. There's no reason to add broken code first and then fix it with a later patch in the same series. -Doug