On Sat, 30 Jan 2021 at 18:23, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, 27 Jan 2021 15:49:23 +0100, Robert Foss wrote: > > Add bindings for qcom,sdm660-camss in order to support the camera > > subsystem on SDM630/660 and SDA variants. > > > > Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx> > > --- > > > > Changes since v2 > > - Rob: Add new line at end of file > > - Rob: Remove redundant descriptions > > - Rob: Add power domain description > > - Rob: Make clock-lanes a constant > > - Rob: Rework to conform to new port schema > > - Add max & minItems to data-lanes > > - Remove ports requirement - endpoint & reg > > - Added Angelo as binding maintainer > > - Removed Todor as binding maintainer > > > > > > .../bindings/media/qcom,sdm660-camss.yaml | 398 ++++++++++++++++++ > > 1 file changed, 398 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/media/qcom,sdm660-camss.example.dts:21:18: fatal error: dt-bindings/clock/qcom,mmcc-sdm660.h: No such file or directory > 21 | #include <dt-bindings/clock/qcom,mmcc-sdm660.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/media/qcom,sdm660-camss.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1370: dt_binding_check] Error 2 This is expected and mentioned in the cover letter due to a dependency on an as of yet unmerged mmcc-sdm660 series. > > See https://patchwork.ozlabs.org/patch/1432255 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
