Re: [PATCH] arm64: dts: qcom: pm8994: Add resin node to PON

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 29 Dec 06:47 CST 2020, Yassine Oudjana wrote:

> From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> Date: Sun, 27 Dec 2020 21:23:40 +0400
> 
> Add resin as a child node of PON.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/pm8994.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> index 5ffdf37d8e31..334774a38602 100644
> --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> @@ -58,6 +58,14 @@ pwrkey {
>  				linux,code = <KEY_POWER>;
>  			};
> 
> +			resin {
> +				compatible = "qcom,pm8941-resin";
> +				interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> +				debounce = <15625>;
> +				bias-pull-up;
> +				linux,code = <KEY_VOLUMEDOWN>;

Is resin always volume down?

Also this node is already defined in apq8096-db820c.dtsi, so how about
moving the common properties here, but leave it status = "disabled" and
then in the device specific file make it status = okay?

Regards,
Bjorn

> +			};
> +
>  		};
> 
>  		pm8994_temp: temp-alarm@2400 {
> --
> 2.29.2
> 



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux