Hi Konrad,
On Sonntag, 24. Jänner 2021 16:04:13 CET Konrad Dybcio wrote:
> > + mdss@fd900000 {
> > + status = "ok";
> > +
> > + mdp@fd900000 {
> > + status = "ok";
> > + };
> > +
> > + dsi@fd922800 {
> > + status = "ok";
> > +
> > + vdda-supply = <&pma8084_l2>;
> > + vdd-supply = <&pma8084_l22>;
> > + vddio-supply = <&pma8084_l12>;
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ports {
> > + port@1 {
> > + endpoint {
> > + remote-
endpoint = <&panel_in>;
> > + data-lanes
= <0 1 2 3>;
> > + };
> > + };
> > + };
> > +
> > + panel: panel@0 {
> > + reg = <0>;
> > + compatible = "samsung,s6e3fa2";
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&panel_pin>;
> > +
> > + port {
> > + panel_in: endpoint {
> > + remote-
endpoint = <&dsi0_out>;
> > + };
> > + };
> > + };
> > + };
> > +
> > + dsi-phy@fd922a00 {
> > + status = "ok";
> > +
> > + vddio-supply = <&pma8084_l12>;
> > + };
> > + };
> >
> > };
>
> Please use &label here. If there's none, add them in msm8974.dtsi.
>
All msm8974 dts(i) files use this style. Deviating from it for this doesn't
make sense. And yes msm8974 should probably be converted to the newer label
style (as was done with msm8916 a while ago).
>
> Konrad
Regards
Luca
