Re: [PATCH v2 14/15] cpufreq: qcom-hw: Implement CPRh aware OSM programming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi AngeloGioacchino,

I love your patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on robh/for-next linux/master linus/master v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/AngeloGioacchino-Del-Regno/Enable-CPRh-3-4-CPU-Scaling-on-various-QCOM-SoCs/20210110-021002
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: arm-randconfig-r022-20210108 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/390ca2a9300484089b567314e6a8c145f0652248
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review AngeloGioacchino-Del-Regno/Enable-CPRh-3-4-CPU-Scaling-on-various-QCOM-SoCs/20210110-021002
        git checkout 390ca2a9300484089b567314e6a8c145f0652248
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from include/linux/math.h:5,
                    from include/linux/kernel.h:13,
                    from include/linux/clk.h:13,
                    from include/linux/cpufreq.h:11,
                    from drivers/cpufreq/qcom-cpufreq-hw.c:11:
   drivers/cpufreq/qcom-cpufreq-hw.c: In function 'qcom_cpufreq_gen_params':
>> arch/arm/include/asm/div64.h:51:36: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      51 | #define do_div(n, base) __div64_32(&(n), base)
         |                                    ^~~~
         |                                    |
         |                                    u32 * {aka unsigned int *}
   drivers/cpufreq/qcom-cpufreq-hw.c:555:3: note: in expansion of macro 'do_div'
     555 |   do_div(millivolts, 1000);
         |   ^~~~~~
   arch/arm/include/asm/div64.h:24:45: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'u32 *' {aka 'unsigned int *'}
      24 | static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
         |                                   ~~~~~~~~~~^
   drivers/cpufreq/qcom-cpufreq-hw.c: In function 'qcom_cpufreq_acd_regbit':
>> arch/arm/include/asm/div64.h:51:36: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      51 | #define do_div(n, base) __div64_32(&(n), base)
         |                                    ^~~~
         |                                    |
         |                                    u32 * {aka unsigned int *}
   drivers/cpufreq/qcom-cpufreq-hw.c:650:2: note: in expansion of macro 'do_div'
     650 |  do_div(regbit, 4);
         |  ^~~~~~
   arch/arm/include/asm/div64.h:24:45: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'u32 *' {aka 'unsigned int *'}
      24 | static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
         |                                   ~~~~~~~~~~^
   drivers/cpufreq/qcom-cpufreq-hw.c: In function 'qcom_cpufreq_hw_read_lut':
>> arch/arm/include/asm/div64.h:51:36: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      51 | #define do_div(n, base) __div64_32(&(n), base)
         |                                    ^~~~
         |                                    |
         |                                    u32 * {aka unsigned int *}
   drivers/cpufreq/qcom-cpufreq-hw.c:1085:3: note: in expansion of macro 'do_div'
    1085 |   do_div(freq, 1000);
         |   ^~~~~~
   arch/arm/include/asm/div64.h:24:45: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'u32 *' {aka 'unsigned int *'}
      24 | static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
         |                                   ~~~~~~~~~~^
   drivers/cpufreq/qcom-cpufreq-hw.c: In function 'qcom_cpufreq_hw_driver_probe':
>> arch/arm/include/asm/div64.h:51:36: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      51 | #define do_div(n, base) __div64_32(&(n), base)
         |                                    ^~~~
         |                                    |
         |                                    long unsigned int *
   drivers/cpufreq/qcom-cpufreq-hw.c:1591:2: note: in expansion of macro 'do_div'
    1591 |  do_div(cpu_hw_rate, soc_data->clk_hw_div);
         |  ^~~~~~
   arch/arm/include/asm/div64.h:24:45: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'long unsigned int *'
      24 | static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
         |                                   ~~~~~~~~~~^
   cc1: some warnings being treated as errors


vim +/__div64_32 +51 arch/arm/include/asm/div64.h

fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  44  
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  45  /*
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  46   * In OABI configurations, some uses of the do_div function
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  47   * cause gcc to run out of registers. To work around that,
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  48   * we can force the use of the out-of-line version for
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  49   * configurations that build a OABI kernel.
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  50   */
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02 @51  #define do_div(n, base) __div64_32(&(n), base)
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  52  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux