On Fri, Jan 08, 2021 at 04:10:11PM +0100, Loic Poulain wrote: > Hi Mani, > > On Fri, 8 Jan 2021 at 13:07, Manivannan Sadhasivam < > manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > On Thu, Dec 10, 2020 at 12:31:32PM +0100, Loic Poulain wrote: > > > Instead of duplicating queuing procedure in mhi_queue_dma(), > > > mhi_queue_buf() and mhi_queue_skb(), add a new generic mhi_queue() > > > as common helper. > > > > > > > While doing the factoring, please don't make any additional changes. If > > you want > > to do, then use incremental patches. > > > > Well, I've not really performed additional change, I've just aligned all > mhi_queue*() to use _irq for locking, but that was already the one used in > mhi_queue_buf(), mhi_queue_dma and mhi_queue_skb now use it as well > (instead bh), but it's because of the factoring. This has been tested > carefully. > And you have removed "pre_alloc" check... Either mention all the changes in the commit message or do it incrementally. Thanks, Mani > Regards, > Loic
