Quoting Tanmay Shah (2020-12-17 14:52:54) > On 2020-12-11 14:36, Stephen Boyd wrote: > > Quoting Krishna Manikandan (2020-12-10 23:09:45) > >> Changes in v10: > >> - Change title of this patch as it does not contain PLL bindings > >> anymore > >> - Remove redundant properties > >> - Remove use of IRQ flag > >> - Fix ports property > >> > >> Previous Change log: > >> https://lkml.kernel.org/lkml/1597066683-6044-2-git-send-email-mkrishn@xxxxxxxxxxxxxx/ > > > > Why can't that be put in here instead of making me click the link? > > > > Thanks Stephen for reviews. > > I just wanted to use space efficiently. But if it helps in reviews, > I will bring all the previous change logs back. Or it can be left under the cut (---). This is probably going to merge through the binding tree so it doesn't follow drm practice of putting version history in the commit text. > > >> diff --git > >> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> new file mode 100644 > >> index 0000000..bc80632 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml [...] > >> + - | > >> + #include <dt-bindings/interrupt-controller/arm-gic.h> > >> + #include <dt-bindings/clock/qcom,dispcc-sc7180.h> > >> + > >> + mdss: mdss { > > > > Can drop the label. Also this node name is bad! Should be > > 'subsystem@<reg>' I guess? And then the reg can just be the first > > address in a reg property that is remapped for the children nodes. > > > > I didn't get this part: > "And then the reg can just be the first address in a reg property that > is remapped for children nodes." > > Does this mean, I should add reg property for mdss node as well? Node > mdss address is 0x0ae00000. So something like: > > reg = <0 0x0ae00000 0 0x1000>; > Yes and then a ranges property so that child nodes can figure out their reg property appropriately. > > > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + interrupt-controller; [...] > >> + remote-endpoint = <&dpu_intf0_out>; > >> + }; > >> + }; > >> + > >> + port@1 { > >> + reg = <1>; > >> + dp_out: endpoint { > > > > Can drop the label and show some remote-endpoint connection? > > > > I am not sure what should I include here as connection. IIRC, Robh > suggested It should connect to the Type-C connector through some sort of > mixing node. However, I see only typec connector node at: > Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml. > Should we use that directly or should we use ec node? > > Can we do something like: > > remote-endpoint = <&typec> or <&ec> Sure. I suppose <&typec> would work.
