On Wed, Dec 16, 2020 at 7:40 PM Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: > > I think I will conjure a patch allowing identical naming only for > > device property naming (like from device tree) but emitting a > > warning so that people fix it to something unique moving > > forward. > > > > I'm not against emitting a dev_err() when we hit duplicates, remove the > return and then update the various dts files to use "" for things that > doesn't have a name. > > Regarding special handling of the DT case, I think (beyond making all > these boards boot again) it would be nice to make > gpiochip_set_desc_names() take the list of names and a length and use > the same function in both code paths... > > PS. strlen(names[i]) is O(N), strcmp(names[i], "") is O(1). OK I'll think of something. I'm pulling these patches out of the stuff for this merge window because they are clearly immature, nobody else is telling me so I have to realize it myself, it takes like three days for me to do that... Yours, Linus Walleij
