Re: [PATCH v9 1/2] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11-12-20, 15:10, Stephen Boyd wrote:
> Quoting Krishna Manikandan (2020-12-10 23:09:44)
> >  .../bindings/display/msm/dpu-sc7180.yaml           | 235 +++++++++++++++++++
> >  .../bindings/display/msm/dpu-sdm845.yaml           | 216 ++++++++++++++++++
> >  .../devicetree/bindings/display/msm/dpu.txt        | 141 ------------
> >  .../display/msm/dsi-common-controller.yaml         | 235 +++++++++++++++++++
> >  .../bindings/display/msm/dsi-controller-main.yaml  | 119 ++++++++++
> >  .../bindings/display/msm/dsi-phy-10nm.yaml         |  64 ++++++
> >  .../bindings/display/msm/dsi-phy-14nm.yaml         |  64 ++++++
> >  .../bindings/display/msm/dsi-phy-20nm.yaml         |  68 ++++++
> >  .../bindings/display/msm/dsi-phy-28nm.yaml         |  64 ++++++
> >  .../devicetree/bindings/display/msm/dsi-phy.yaml   |  81 +++++++
> >  .../devicetree/bindings/display/msm/dsi.txt        | 249 ---------------------
> >  11 files changed, 1146 insertions(+), 390 deletions(-)
> 
> This is quite a bit to review. Any chance to split it up into different
> patches? Looks like that could be: dpu, phy, and dsi to make this a bit
> more reviewable.

Yes that would certainly be very helpful for review.

Also I noticed that phy binding seem quite similar with few additions,
can we add a single binding document which documents .. or maybe check
with Rob.. what is the guidance, single doc or multiple..?

-- 
~Vinod



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux