Re: [PATCH] mmc: sdhci-msm: Warn about overclocking SD/MMC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Doug Anderson (2020-12-10 13:20:03)
> On Thu, Dec 10, 2020 at 1:03 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> >
> >
> > Can we use dev_warn?
> 
> What's here matches other prints including other ones in the same
> function and in much of the MMC subsystem.  mmc_hostname() shows
> "mmc1"
> 
> > dev_warn(mmc_dev(mmc)
> > dev_warn(&msm_host->pdev->dev
> 
> This show "sdhci_msm 7c4000.sdhci"
> 
> I'm going to keep with tradition and keep using mmc_hostname().  In
> some parts of this file they use both (a dev_warn that also includes
> the mmc_hostname()) but that feels overkill.

Ok. This driver should be cleaned up I suppose.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux