On Tue 08 Dec 11:08 CST 2020, J.R. Divya Antony wrote:
> ASUS Zenfone 2 Laser Z00L is a smartphone based on MSM8916 SoC
> released on 2015.
>
> Add a device tree for Z00L with initial support for:
> - SDHCI (internal storage)
> - USB Device Mode
> - UART
> - Regulators
>
> Signed-off-by: J.R. Divya Antony <d.antony.jr@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../arm64/boot/dts/qcom/msm8916-asus-z00l.dts | 160 ++++++++++++++++++
> 2 files changed, 161 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 5113fac80b7a..6a4be237f344 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
> dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-z00l.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-longcheer-l8150.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts b/arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts
> new file mode 100644
> index 000000000000..c7307a310781
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts
> @@ -0,0 +1,160 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +/dts-v1/;
> +
> +#include "msm8916-pm8916.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + model = "Asus Zenfone 2 Laser";
> + compatible = "asus,z00l", "qcom,msm8916";
> +
> + aliases {
> + serial0 = &blsp1_uart2;
> + };
> +
> + chosen {
> + stdout-path = "serial0";
> + };
> +
> + usb_id: usb-id {
> + compatible = "linux,extcon-usb-gpio";
> + id-gpios = <&msmgpio 110 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb_id_default>;
> + };
> +};
> +
> +&blsp1_uart2 {
> + status = "okay";
> +};
> +
> +&usb {
It's very convenient to keep labels sorted alphabetically.
Apart from that I think this looks good.
Regards,
Bjorn
