AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx> 于2020年12月5日周六 上午2:04写道: > > Il 04/12/20 08:53, Jun Nie ha scritto: > > Add RPM based interconnect driver implements the set and aggregate > > functionalities that translates bandwidth requests into RPM messages. > > These modules provide a common set of functionalities for all > > Qualcomm RPM based interconnect providers and should help reduce code > > duplication when adding new providers. > > > > Signed-off-by: Jun Nie <jun.nie@xxxxxxxxxx> > Hello! > I agree, the RPM based ICC should be commonized... in any case, I think > that you should rebase your patch series over mine, where I am adding > support for SDM660 and also introducing a mechanism to set QoS, which > can actually be used by most platforms managing the ICC over RPM. > > Please, check it out: https://lore.kernel.org/patchwork/patch/1322131/ > > Thanks, > Angelo > Angelo, Thanks for your contribution! It looks like a great new feature. But they are not ready for other qnoc icc drivers yet. It should not be included in this commonization patch set until someone add and test the feature for all qnoc drivers. Regards, Jun