On Thu 03 Dec 13:13 CST 2020, Dmitry Baryshkov wrote: [..] > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml > new file mode 100644 > index 000000000000..1ddeb25cbdc1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,smem.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: Qualcomm Shared Memory Manager binding > + > +maintainers: > + - Andy Gross <agross@xxxxxxxxxx> > + - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > + > +description: | > + This binding describes the Qualcomm Shared Memory Manager, used to share data > + between various subsystems and OSes in Qualcomm platforms. > + > +properties: > + compatible: y/-/,/ in that compatible, and we only have one. So I think you should instead do: const: "qcom,smem" Apart from that I think the binding looks good. Regards, Bjorn > + enum: > + - "qcom-smem" > +
