Hi, On Fri, Nov 20, 2020 at 10:24 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > There's a proximity sensor on Lazor devices, but only for LTE SKUs. > Enable it only on the Lazor LTE SKUs and also configure it properly so > it works. > > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > > Changes from v2 (https://lore.kernel.org/r/20201120074508.3236616-1-swboyd@xxxxxxxxxxxx): > * Also disabled ap_sar_sensor_i2c node in trogdor.dtsi file > > Changes from v1 (https://lore.kernel.org/r/20201118045454.2503325-1-swboyd@xxxxxxxxxxxx): > * Fixed startup-sensor property to be 0 instead of 1 > * Fixed proxraw-strength to be 8 instead of 2 > > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dts | 8 ++++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 8 ++++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 7 ++++++- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 - > 4 files changed, 22 insertions(+), 2 deletions(-) I haven't personally reviewed the actual numbers for the SAR sensor config, but things look sane. One last nit you could fix upstream is the removal of the "disabled" in "sc7180-trogdor-r1.dts" now that it's disabled by default... In any case... Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
