On Tue, 10 Nov 2020, Bjorn Andersson wrote:
> On Tue 03 Nov 09:28 CST 2020, Lee Jones wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/soc/qcom/smp2p.c:74: warning: Function parameter or member 'flags' not described in 'smp2p_smem_item'
> > drivers/soc/qcom/smp2p.c:149: warning: Function parameter or member 'out' not described in 'qcom_smp2p'
> >
> > Cc: Andy Gross <agross@xxxxxxxxxx>
> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> > drivers/soc/qcom/smp2p.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
> > index a9709aae54abb..43df63419c327 100644
> > --- a/drivers/soc/qcom/smp2p.c
> > +++ b/drivers/soc/qcom/smp2p.c
> > @@ -52,7 +52,6 @@
> > * @remote_pid: processor id of receiving end
> > * @total_entries: number of entries - always SMP2P_MAX_ENTRY
> > * @valid_entries: number of allocated entries
> > - * @flags:
> > * @entries: individual communication entries
> > * @name: name of the entry
> > * @value: content of the entry
> > @@ -65,7 +64,6 @@ struct smp2p_smem_item {
> > u16 remote_pid;
> > u16 total_entries;
> > u16 valid_entries;
> > - u32 flags;
>
> This struct describes the data shared between processors in the SoC and
> as such these 32 bits are significant. I believe we have an incoming
> patch that adds handling of some flag, so let's document it properly
> at that time.
Sounds reasonable.
> I've applied the second half of the patch for now.
Thanks. And for the other applied patches too.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
