On Thu 05 Nov 03:56 CST 2020, Rajendra Nayak wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c [..] > +static const struct msm_pinctrl_soc_data sc7280_pinctrl = { > + .pins = sc7280_pins, > + .npins = ARRAY_SIZE(sc7280_pins), > + .functions = sc7280_functions, > + .nfunctions = ARRAY_SIZE(sc7280_functions), > + .groups = sc7280_groups, > + .ngroups = ARRAY_SIZE(sc7280_groups), > + .ngpios = 176, I presume the wakeirq_map will come later. Nothing to hold up this patch for, but please help me remember to not merge the tlmm node with a wakeup-parent specified before that. Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> Regards, Bjorn