On 09/11/2020 20:53, Nicolas Dufresne wrote: > Le lundi 09 novembre 2020 à 19:31 +0200, Stanimir Varbanov a écrit : >> Hello, >> >> This patchset adds two HDR10 HEVC v4l2 controls for Content Light Level >> and Mastering display colour volume plus implenmentation in Venus encoder >> driver. >> >> Comments are welcome! > > It is not a formal review, but I did walked through the new API and > everything looks fine to me. One question though, are you aware that > the H.264/AVC equivalent is identical ? What is you plan for that ? Not only that, but these structures are lifted straight from the CTA-861-G standard: see "6.9 Dynamic Range and Mastering InfoFrame" and "6.9.1 Static Metadata Type 1". So this is equally useful for HDMI receivers and transmitters. Actually, include/linux/hdmi.h contains a struct for that, but it seems to be missing a lot of fields. But we need a v4l2 control anyway and hdmi.h isn't a good fit for that. Regards, Hans > >> >> regards, >> Stan >> >> Stanimir Varbanov (3): >> v4l: Add HDR10 HEVC static metadata controls >> docs: media: Document CLL and Mastering display >> venus: venc: Add support for CLL and Mastering display controls >> >> .../media/v4l/ext-ctrls-codec.rst | 61 +++++++++++++++++++ >> drivers/media/platform/qcom/venus/core.h | 3 + >> drivers/media/platform/qcom/venus/hfi_cmds.c | 8 +++ >> .../media/platform/qcom/venus/hfi_helper.h | 20 ++++++ >> drivers/media/platform/qcom/venus/venc.c | 29 +++++++++ >> .../media/platform/qcom/venus/venc_ctrls.c | 16 ++++- >> drivers/media/v4l2-core/v4l2-ctrls.c | 61 +++++++++++++++++++ >> include/media/hevc-ctrls.h | 41 +++++++++++++ >> include/media/v4l2-ctrls.h | 2 + >> 9 files changed, 240 insertions(+), 1 deletion(-) >> >
