On 11/5/2020 6:56 PM, Prasad Sodagudi wrote: > This patch series adds register read/write event tracing > support. Qualcomm team tried upstreaming the register > trace buffer solution - [1] with pstore and dynamic debug > feature but that patch series didn't merge. I have followed > Steve suggestion from -[2] and used tracepoint_enabled() API. > > [1] - https://patchwork.kernel.org/project/linux-arm-msm/cover/cover.1536430404.git.saiprakash.ranjan@xxxxxxxxxxxxxx/ > [2] - https://lore.kernel.org/lkml/20200928105501.7e29df65@xxxxxxxxxxxxxxxx/ > > Qualcomm teams uses these logs for debugging various issues > in the product life cycle and hopping that this logging > would help other silicon vendors as this is generic approach. There is not anything arm64 specific here other than where you have hooked into the low-level I/O accessors, you could consider adding this as a generic facility to other architectures as well. Also, have you looked at making mmiotrace less x86 specific and more generic? -- Florian