On 10/30/2020 2:18 AM, mka@xxxxxxxxxxxx wrote:
On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote:
Register GPU as a devfreq cooling device so that it can be passively
cooled by the thermal framework.
Signed-off-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxx>
Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
Wait, I did not post a 'Reviewed-by' tag for this patch!
I think the patch should be ok, but I'm still not super happy
about the resource management involving devfreq in general (see
discussion on https://patchwork.freedesktop.org/patch/394291/?series=82476&rev=1).
It's not really something introduced by this patch, but if it ever
gets fixed releasing the cooling device at the end of
msm_gpu_cleanup() after everything else might cause trouble.
In summary, I'm supportive of landing this patch, but reluctant to
'sign it off' because of the above.
In any case:
Tested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
Sorry, Matthias. My mistake. You shared the reviewed tag for the
dt-bindings update. Will fix this ASAP. Thanks for verifying this.
-Akhil.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
