Re: [v3,2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

[Akhil P Oommen <akhilpo@xxxxxxxxxxxxxx>]

On 10/29/2020 6:09 AM, mka@xxxxxxxxxxxx wrote:
> Hi Akhil,
>
> On Wed, Oct 28, 2020 at 07:09:53PM +0530, Akhil P Oommen wrote:
> > Add cooling-cells property and the cooling maps for the gpu tzones
> > to support GPU cooling.
> >
> > Signed-off-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++++++++++++++++++++++-------
> >   1 file changed, 23 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index d46b383..a7ea029 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -2,7 +2,7 @@
> >   /*
> >    * SC7180 SoC device tree source
> >    *
> > - * Copyright (c) 2019, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2019-20, The Linux Foundation. All rights reserved.
> >    */
> >   
> >   #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
> > @@ -1886,6 +1886,8 @@
> >   			operating-points-v2 = <&gpu_opp_table>;
> >   			qcom,gmu = <&gmu>;
> >   
> > +			#cooling-cells = <2>;
> > +
> >   			interconnects = <&gem_noc MASTER_GFX3D &mc_virt SLAVE_EBI1>;
> >   			interconnect-names = "gfx-mem";
> >   
> > @@ -3825,16 +3827,16 @@
> >   		};
> >   
> >   		gpuss0-thermal {
> > -			polling-delay-passive = <0>;
> > +			polling-delay-passive = <100>;
> >   			polling-delay = <0>;
> >   
> >   			thermal-sensors = <&tsens0 13>;
> >   
> >   			trips {
> >   				gpuss0_alert0: trip-point0 {
> > -					temperature = <90000>;
> > +					temperature = <95000>;
> >   					hysteresis = <2000>;
> > -					type = "hot";
> > +					type = "passive";
> >   				};
> >   
> >   				gpuss0_crit: gpuss0_crit {
> > @@ -3843,19 +3845,26 @@
> >   					type = "critical";
> >   				};
> >   			};
> > +
> > +			cooling-maps {
> > +				map0 {
> > +					trip = <&gpuss0_alert0>;
> > +					cooling-device = <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +				};
> > +			};
> >   		};
> >   
> >   		gpuss1-thermal {
> > -			polling-delay-passive = <0>;
> > +			polling-delay-passive = <100>;
> >   			polling-delay = <0>;
> >   
> >   			thermal-sensors = <&tsens0 14>;
> >   
> >   			trips {
> >   				gpuss1_alert0: trip-point0 {
> > -					temperature = <90000>;
> > +					temperature = <95000>;
> >   					hysteresis = <2000>;
> > -					type = "hot";
> > +					type = "passive";
> >   				};
> >   
> >   				gpuss1_crit: gpuss1_crit {
> > @@ -3864,6 +3873,13 @@
> >   					type = "critical";
> >   				};
> >   			};
> > +
> > +			cooling-maps {
> > +				map0 {
> > +					trip = <&gpuss0_alert0>;
>
> Copy & paste error, this should be 'gpuss1_alert0'.
aah! you are correct.

--Akhil
> > +					cooling-device = <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +				};
> > +			};
> >   		};
> >   
> >   		aoss1-thermal {
>
>
> Other than the C&P error:
>
> Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel